Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-Error object exceptions handled incorrectly [patch included #153

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

1.) What Tampermonkey version do you use? (go to 'chrome://extensions/' for
that information)
r103

2.) What browser version (go to 'chrome://chrome/') and operating system do
you use?
Windows 7 x64,  chrome 27.0.1453.116 m, OSX 10.8.4 Chrome Version 27.0.1453.110

3.) Does a Userscript cause the problem? If so, from where can it be
downloaded?
Edit new userscript and write this one line below the userscript comments:

    throw 'error string';

4.) Did this work before? Have you checked the script's bug
tracker/discussion page for that problem?
As far as I can tell, non-Error object exceptions have always been handled 
incorrectly.

5.) Are there other Userscripts installed and running?
yes.

6.) Steps to reproduce the problem:
a.  Edit userscript as shown in step 3) and reload any site

7.) What is the expected behavior? What went wrong?
Non-Error object exceptions shouldn't cause the userscript to blow up.

Original issue reported on code.google.com by aggie...@gmail.com on 20 Jun 2013 at 10:25

@GoogleCodeExporter
Copy link
Author

I fat fingered the enter key when typing the subject.  Patch included here:

Original comment by aggie...@gmail.com on 20 Jun 2013 at 10:27

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by derj...@googlemail.com on 21 Jun 2013 at 10:07

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Fixed at TM Beta: 
http://tampermonkey.net/changelog.php?version=3.2.3450&ext=gcal

Original comment by derj...@googlemail.com on 21 Jun 2013 at 5:59

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by derj...@googlemail.com on 4 Jul 2013 at 1:42

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant