My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 52: prefer the enhanced for loop
  Back to list
Status:  Fixed
Owner:  benpi...@googlemail.com
Closed:  Mar 2011


 
Reported by jdswpdat, Mar 21, 2011
In utils.DataNodeArrayItemizedOverlay.updateItem()

Use the more efficient extended for-loop (foreach) instead of the explicite,index-driven for-loop.

replace 

<code:java>
   for (int i = 0; i < overlayItems.size(); ++i)
                if (overlayItems.get(i).second.intValue() == id) {
                    OverlayItem oi = Helper.getOverlayItem(pos,
                            overlayItems.get(i).first.getMarker());
                    overlayItems.get(i).first = oi; // update the OverlayItem
                                               
</code>

with

<code:java>
  for ( Pair<OverlayItem,Integer> overlayItem : overlayItems) {
                if (overlayItem.second.intValue() == id) {
                    OverlayItem oi = Helper.getOverlayItem(pos,
                            overlayItem.first.getMarker());
                    overlayItem.first = oi; // update the OverlayItem
</code>

Mar 21, 2011
Project Member #1 SakirS...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Owner: benpi...@googlemail.com
Mar 21, 2011
Project Member #2 thi...@inf.fu-berlin.de
Can you proove that the extended for-loop is really more efficient?
Mar 22, 2011
Project Member #3 benpi...@googlemail.com
(No comment was entered for this change.)
Status: Started
Mar 22, 2011
Project Member #4 benpi...@googlemail.com
(No comment was entered for this change.)
Status: Fixed

Powered by Google Project Hosting