Export to GitHub

svgweb - issue #378

Undefined variable in svg.js source code


Posted on Nov 3, 2009 by Happy Rabbit

Hi,

I edit the svg.js file with Netbeans. I noticed this:

  • lign 312 : warning problem assigned :
    while (current = result.iterateNext()) { Instead of while ((current = result.iterateNext())) {

  • lign 7464 : bad cut and paste ;-) flash.setAttribute

  • there are many redeclaration variables.

  • there are many warnings for "function does not always return a value".

Comment #1

Posted on Nov 3, 2009 by Massive Bird

NetBeans probably has a basic JavaScript syntax checker. I'm doing some pretty funky stuff in svg.js that a basic JS syntax checker would probably get confused about, using lots of closures, anonymous functions, etc. The issue on line 312 seems real but the others seem spurious.

Comment #2

Posted on Nov 3, 2009 by Massive Bird

(No comment was entered for this change.)

Comment #3

Posted on Nov 3, 2009 by Massive Bird

Other lines that have issues:

line 1176

Comment #4

Posted on Nov 10, 2009 by Massive Bird

(No comment was entered for this change.)

Comment #5

Posted on Nov 19, 2009 by Massive Bird

(No comment was entered for this change.)

Comment #6

Posted on Dec 2, 2009 by Massive Bird

This issue was closed by revision r1029.

Status: Fixed

Labels:
Type-Defect Priority-Low Patch