Issue 57: OrderHelper and SubstructApplicationController are in wrong places.
Status:  Accepted
Owner: ----
Reported by edmundo...@gmail.com, Mar 18, 2008
The way it is, it works but I don't agree that these files should be where
they are.

order_helper.rb as a helper should be in the helpers directory not in
controllers.

substruct_application_controller.rb isn't even a controller as it doesn't
descend from ApplicationController nor ActionController::Base, its just a
module with methods and as such I think it should be in /lib.

You can find some suggestions that James Adam (the creator of engines) and
other people gave in the engines mailing list, about placing it in /lib and
including it in application.rb or using module inclusion with
ActionController::Base inside init.rb.

References:
http://www.mail-archive.com/engine-users@lists.rails-engines.org/msg01054.html
http://www.mail-archive.com/engine-users@lists.rails-engines.org/msg00963.html

I cannot make a patch for this as it include moving files around and
renaming files.
Apr 9, 2008
Project Member #1 subim...@gmail.com
OrderHelper really isn't a "helper" in Rails terms. I probably just named it wrong. It's a mixin that contains 
controller code. I don't really see anywhere else it should go. It doesn't make sense to go in the helpers 
directory.

If you'd like to propose a working situation to move SubstructApplicationController, please let me know what 
should be moved, and provide a patch for the rest.


Status: Accepted
Labels: -Priority-Medium Priority-Low
Apr 13, 2008
#2 edmundo...@gmail.com
Ok, I saw it again and it really have controller code. In that case I think its
better to have tests of the ordering part before propose things to be moved around.