Issue 46: SAMPLE Simpler navigation bar highlight code.
Status:  Accepted
Owner: ----
Reported by edmundo...@gmail.com, Mar 11, 2008
I substituted all methods that does the highlight by just one, as nothing
is broken this is not a fix. I think this way its much more simpler to
understand, the functionality should be the same. It was changed directly
inside /vendor/plugins/substruct.

Follows a diff, my working copy is so messed with changes not committed
that its hard to separate issues that I filled to make a diff just with one :P

It needs that app/controllers/application.rb be this:

class ApplicationController < ActionController::Base
  include SubstructApplicationController  
  before_filter :set_navigation_tabs
  before_filter :find_customer
end

This change is out of the scope of the subversion repository.
simpler_navigation_highlight.patch
6.9 KB   View   Download
Mar 13, 2008
#1 edmundo...@gmail.com
The last patch broke tab highlight inside the admin module as it needs @cname and
@aname too. Greping the code shows that its used only in the admin layout, it should
work now.

Follows the previous patch fixed.
simpler_navigation_highlight fixed.patch
6.9 KB   View   Download
Apr 8, 2008
Project Member #2 subim...@gmail.com
Not really the way I'd like to see this solved. By cleaning up I meant removing more crap from the 
application_controller.

Don't like this approach, so I'm rejecting & setting to a low priority.
Labels: -Priority-Medium Priority-Low
Apr 9, 2008
Project Member #3 subim...@gmail.com
Is there a way to combine this with  issue 45 ?
Status: Accepted
Apr 9, 2008
#4 edmundo...@gmail.com
I don't understood why, its two different things, is really  issue 45  that you are
talking about?

 Issue 45  is just a change in a "find" call to not break a test or break the interface
when the database wasn't populated using the administration interface (I normally
import fixtures in the development environment with random ids (foxy fixtures dont
need to have ids) to start to work with the interface).