My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 99: PATCH The system gives a wrong list of products accepting invalid tags in the front face site. (related with issue 96)
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Aug 2008


 
Reported by edmundo...@gmail.com, Jun 17, 2008
What steps will reproduce the problem?
1. Enter an URL that have an invalid tag at the address bar and a subtag
together. i.e.
http://localhost:3000/store/show_by_tags/valid/invalid
or
http://localhost:3000/store/show_by_tags/invalid/valid

What is the expected output? What do you see instead?
It should show a 404 page. It shows a product list using the invalid tag.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.10

Please provide any additional information below.
It was fixed wrong, I maintained the 404 behavior and put the render in the
right place, as sometimes the hash can contain a valid tag when an invalid
one was passed together. It has an unreable part too, the @tag_names var
will never evaluate to false as the tags param will be an empty hash when
no tag is passed.
 
wrong_result_with_show_by_tags_with_invalid_tag.patch
959 bytes   View   Download
Aug 11, 2008
Project Member #1 subim...@gmail.com
Thanks, fixed in r110
Status: Fixed

Powered by Google Project Hosting