My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 88: Removing all shipping rates results in multiple failures
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Aug 2008


 
Reported by charles....@gmail.com, May 13, 2008
If you remove all shipping rates through the admin panel, when you attempt
to save the shipping, you get a 500 error, even though you're able to
return later and see no shipping rates. When checking out an item, there
will be no shipping to select, and hitting the send button to continue
there will be a 500 error effectively preventing the customer from
completing a checkout.

Workaround: adding new shipping rates or adding a single 0 dollar shipping
rate will fix this issue.
Aug 15, 2008
Project Member #1 subim...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Labels: -Priority-Medium Priority-High
Aug 26, 2008
#2 sclarkla...@gmail.com
I think I fixed this but now I need to figure out how to make a patch quick. 
all this does is prevent you from saving if you delete all the rates. I'll try to
come up with a more robust solution.

this is what I did:

 def save_shipping
    # Index is the shipping type ID.
    if(params[:shipping_types].nil?)
        flash[:notice] = "Please Add At least one Shipping rate."
        redirect_to :action => 'shipping'
    else
    params[:shipping_types].each do |id,type_attributes|
      type = OrderShippingType.find(id)
      type.update_attributes(type_attributes)
    end
    flash[:notice] = "Shipping Rates Saved."
    redirect_to :action => 'shipping'
    end
  end
Aug 27, 2008
#3 charles....@gmail.com
That work-around will work in preventing a crash from happening.  What about adding a
prompt so that the administrator can add a zero dollar shipping rate if they don't
want shipping? (you run into that with a website that sells only downloads, or runs
on donations)
Aug 28, 2008
Project Member #4 subim...@gmail.com
Fixed in r150.

I ensured there is no error saving rates, and no errors happens on the store side
during checkout.

Still this poses an interesting design discussion. Perhaps we should be able to
eliminate the shipping step all together if there are no rates, or through preferences.
Status: Fixed

Powered by Google Project Hosting