My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 79: PATCH user's authenticate? method have an unreachable part
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jun 2008


 
Reported by edmundo...@gmail.com, Apr 21, 2008
This problem doesn't give an error on the interface.

rcov keeps showing that theres a part of the method thats never reached.

def self.authenticate?(login, pass)
  user = self.authenticate(login, pass)
  return false if user.nil?
  return true if user.login == login

  false
end

Or authenticate return nil or the right user as it finds by login, theres
not a third possibility to need to return false.

The patch fixes it

Version used: trunk

user_authenticate?.patch
723 bytes   View   Download
Jun 15, 2008
Project Member #1 subim...@gmail.com
Returning false at the end is just a safeguard...in case ;)
Status: WontFix

Powered by Google Project Hosting