My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 61: Promotions (percentages) | discount inaccurate for discounts below 101%
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Jun 2008


 
Reported by surveys...@gmail.com, Mar 19, 2008
What steps will reproduce the problem?
1. Create a new promotion for 50%
2. Enter promotion code at checkout
3.  Continue to shipping page

What is the expected output? What do you see instead?
Discount reflecting 50%, instead it displays a discount 25% (16% off for discounts set at either 
20% or 80%) etc.

What version of the product are you using? On what operating system?
release 1-0-a2, Linux

Please provide any additional information below.

 Discounts set above 100% (ie. 120% or 140%) will reflect the actual amount in the total.
Mar 20, 2008
#1 johnd...@gmail.com
This has uncovered a small security issue, add a promo at 50%. Buy a €10 product and
enter your code, select shipping and goto payment. You get five euro off - cool.
Clear the cart and do it again but this time before the final submit your order for
payment go home and add the product again (as if you wanted to continue shopping),
checkout and you'll see your order total as €20, fine. Now  enter your details and
the promo code and the second product drops off, opps, and this time the promo
discount is applied to the total inc shipping, not so cool. 
I've no fix for this, its a bit over my head
Apr 27, 2008
#2 edmundo...@gmail.com
I can't confirm the original issue about the wrong 50% discount but can confirm the
comment about the second product disappearing and the discount being applied to the
product + shipping price. And maybe its related with  issue 54 , I didn't get in the
controller test yet.

Tested on trunk. 
Apr 27, 2008
#3 edmundo...@gmail.com
I was looking again at how promotions are applied and appears that I didn't
understood at first time how promotions are supposed to work.

The promotion using a percentage is not being applied right to the FIRST checkout
(when the shipping wasnt choosed yet) because it really was made to be applied to the
TOTAL order value (and this not only should include shipping but taxes too).
Jun 14, 2008
Project Member #4 subim...@gmail.com
Actually I believe it is a bug, and the promotion should be applied only to order total, not shipping. Patch 
anyone?
Status: Accepted
Jun 15, 2008
Project Member #5 subim...@gmail.com
Fix for the line items total issue done in r98


Status: Fixed

Powered by Google Project Hosting