My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 117: store/product view partial isn't MVC
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Aug 2008


 
Reported by paul.g.m...@gmail.com, Aug 15, 2008
This is a code refactoring

The store/product partial is not MVC, the display html is all embedded in a
helper.

(My graphic designer wasn't overly keen on trying to edit the helper function!)

Patch attached
 
mvc_product_view.diff
3.6 KB   View   Download
Aug 15, 2008
Project Member #1 subim...@gmail.com
Good idea for a patch, bad execution.

Please test / debug your code before submitting in the future. Image path was wrong
and some variables not set correctly.

Could cause issues when upgrading, so making a note of this.

...Fixed in r124
Status: Fixed
Aug 17, 2008
#2 paul.g.m...@gmail.com
Urgh! Apologies, looks like I attached a duff file. 


Powered by Google Project Hosting