My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 112: last item can be bought by more than one person as long as they both have it in their cart before one of them confirms order
2 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


 
Reported by xmischi...@gmail.com, Jul 25, 2008
What steps will reproduce the problem?
1. When there is 1 item of a product left it will allow 2 people to buy it
if person1 places it into their cart before person2 confirms their order in
the last step of check out.

What is the expected output? What do you see instead?
I would think the completion of the sale of an item would hinge upon it's
availability at the time of order confirmation, not just upon its
availability when adding to the cart.

I see negative numbers in my inventory!


What version of the product are you using? On what operating system?
substruct_rel_1-0-a3 on Apache 2.2.8 on Linux



 
Jul 30, 2008
#1 edmundo...@gmail.com
Here goes a patch, it cannot be tested with tests so Im making something that in
theory seems right and doesn't break anything. Theres a high possibility that it
cannot be applied clean as my working copy has some other patches.

The test coverage was run again and at least it doesn't break and recover the stock
quantity on errors.

Follows a text file with something to illustrate what I think a worst case scenario.

It uncover another problem with the administrative interface, when the order status
is changed manually, probably it makes the stock be out of sync.

Regards.
concurrent_stock_update.patch
7.8 KB   View   Download
trigger.txt
442 bytes   View   Download
wrost_case.txt
836 bytes   View   Download
Aug 11, 2008
Project Member #2 subim...@gmail.com
I'm sleeping on this issue until I take a good look at the discussion here:

http://groups.google.com/group/substruct/browse_thread/thread/c641b5bed312f489/83324428408f29f4
Aug 15, 2008
Project Member #4 subim...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Labels: -Priority-Medium Priority-Low
Oct 30, 2008
#5 rogerpack2005
Also [sorry can't find the issue] need to make sure that if users add more to their
inventory after "aborting" a checkout that they get charged tax and shipping is
recalculated for their order.

Powered by Google Project Hosting