My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 106: PATCH Dynamic apply/unapply TLS monkey patch using preferences.
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Sep 2008


 
Reported by edmundo...@gmail.com, Jul 2, 2008
I added a preference to apply the patch or reload the original ruby smtp class.

It needs some testing yet.

Follows the patch
tls_patch_preference.patch
4.7 KB   View   Download
Jul 2, 2008
#1 edmundo...@gmail.com
Corrected a typo, a problem reloading the smtp class and tested.

Im not including the test unit as it points to real servers.
tls_patch_preference_v2.patch
4.6 KB   View   Download
Aug 11, 2008
Project Member #2 subim...@gmail.com
The patch cleanly applies, but has the following problems...

1 - Missing a db migration to add the preference (attached)
2 - Makes the unit tests error out. Can you check this against trunk?
030_gmail_ssl_support.rb
251 bytes   View   Download
Status: Accepted
Labels: -Priority-Medium Priority-High
Aug 12, 2008
#3 edmundo...@gmail.com
I was 10 days without internet connection (I was moving from my appartment) I will
take a look at this and update the tests. As I said in  issue 8  the tests aren't
updated anymore, every time something is added/changed the tests are/need to be
changed too.
Aug 14, 2008
#4 edmundo...@gmail.com
Probably its just missing the preference inside the preferences fixture?
Aug 17, 2008
Project Member #5 subim...@gmail.com
Pushing on this until  issue 119  is fixed.
Aug 22, 2008
Project Member #6 subim...@gmail.com
Fixed, r140
Status: Fixed
Sep 19, 2008
Project Member #9 subim...@gmail.com
Nevermind :p
Status: Fixed

Powered by Google Project Hosting