My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 101: PATCH Some cart partials are not being used and some ajax helper methods makes reference to a DOM node that does not exist
1 person starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


 
Reported by edmundo...@gmail.com, Jun 28, 2008
What steps will reproduce the problem?
1. It doesn't break anything, what doesn't means its right either.  

What version of the product are you using? On what operating system?
Trunk. Ubuntu 7.10

Please provide any additional information below.
Appears that the cart and cart_container partials arent used (if anyone
needs it I think they should hold it inside /app), the cart partial is
referenced in some places of store controller, but the actions can simply
render nothing returning an state of success (as the result of the partial
never goes to the screen anyway). In the views, the form_remote_tag or
link_to_remote helper methods can simply ommit the update option, then an
Ajax.Request object will be created instead of an Ajax.Updater. Anyway a
DOM node pointed by it is never manipulated, always an entire show_cart
view inside the modal window is shown or reloaded, using showPopWin() or
window.location.reload() on complete. 

uneeded_cart_partials.patch
3.2 KB   View   Download
Aug 11, 2008
Project Member #1 subim...@gmail.com
I'm skeptical of getting rid of this in case people are relying on it when upgrading
from older versions.

Keeping this around for future consideration.
Status: Accepted
Aug 12, 2008
#2 edmundo...@gmail.com
I think that if people want to continue using it they need to move it to /app its
outside the scope of the system maintain that. Methods can be deprecated, but about
views I don't know what is the best way to inform that it will be removed.
Aug 12, 2008
Project Member #3 subim...@gmail.com
Just removing the files and telling people to move to /app doesn't work. If there's
not a comprehensive list of what will be going away people will be blindsided if they
upgrade, then have to go search out where the old files are.

I don't have a good solution for this now either, which is why the files are staying.

Powered by Google Project Hosting