Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper tab nick-completion #69

Closed
rufuscoder opened this issue Jun 8, 2013 · 6 comments
Closed

Proper tab nick-completion #69

rufuscoder opened this issue Jun 8, 2013 · 6 comments

Comments

@rufuscoder
Copy link
Owner

Original author: void...@gmail.com (May 20, 2008 12:43:34)

Currently nick completion only works at the start of the line, this patch
should let it work anywhere in the chat input field. It also cycles through
all nicks, wraps back to the original string, then keeps cycling again.

NB: This was written based on the 0.9.5 source, and I can't get the 0.9.7
SVN compiling yet. This should still work though.

Original issue: http://code.google.com/p/shakespeer/issues/detail?id=12

@rufuscoder
Copy link
Owner Author

From void...@gmail.com on May 20, 2008 13:27:31
Actually, that conflicts with the change from 0.9.5 to 0.9.7 on line 208 of
SPHubController.m:

return [array sortedArrayUsingDescriptors:[userTable sortDescriptors]]

changing it back to:

return array;

makes it work. Not sure what else that effects though.

@rufuscoder
Copy link
Owner Author

From hwa...@gmail.com on May 20, 2008 16:54:22
Any idea why the change in comment 1 is needed? Does nick autocompletion not want the
nicks back sorted?

The reason that method returns a sorted array, is so the userlist table gets the
right sorting when it is filtered (see the userlist quick search).

@rufuscoder
Copy link
Owner Author

From void...@gmail.com on May 20, 2008 17:42:46
Without the change in comment 1, it doesn't work. It just returns the following error:

2008-05-21 03:42:17.965 ShakesPeer[32544:10b] [<NSCFString 0x1a4164a0>
valueForUndefinedKey:]: this class is not key value coding-compliant for the key nick.

@rufuscoder
Copy link
Owner Author

From void...@gmail.com on May 20, 2008 17:57:18
Oh yeah, I see how it loses the sorting without that line. I'm not sure how to fix it.

@rufuscoder
Copy link
Owner Author

From hwa...@gmail.com on May 20, 2008 18:15:27
Ah, I think the problem is that this function may either return SPNick objects or
NSStrings. The sort descriptors only work on the array if it contains SPNicks.

I'll fix that problem and commit the patch. Thanks!

@rufuscoder
Copy link
Owner Author

From hwa...@gmail.com on May 20, 2008 18:33:03
Committed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant