Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 Tags have superfluous space #701

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 7 comments
Closed

HTML5 Tags have superfluous space #701

GoogleCodeExporter opened this issue Mar 25, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

I've been using Nick Ager's Seafox code on Html5 docs and wanted it to output

html header:[].
rather than:
html tag:'header' with:[]

In the attached package I went through the *seaside-html5 extensions to the 
WAHtmlCanvas and added classes for each tag that didn't have one. 

So

WAHtmlCanvas>>#header
^self tag: 'header'

becomes

WAHtmlCanvas>>#header
^self brush:WAHeaderTag new


With this seafox outputs what I want.  

Original issue reported on code.google.com by pdebr...@gmail.com on 14 Jan 2012 at 8:21

Attachments:

@GoogleCodeExporter
Copy link
Author

hmm this seems like more of a bug with Seafox

Original comment by Nick.A...@gmail.com on 20 Jan 2012 at 4:32

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Sure.  But I didn't know the justification for why some Html5 elements 
got their own subclasses of WATagBrush and others only got a method on 
the WAHtmlCanvas.

I posted this here because it seemed to me that those additional 
subclasses may be more useful than only as a extension to the Seafox 
package.

Original comment by pdebr...@gmail.com on 20 Jan 2012 at 4:41

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

The rule of thumb is everything that needs more methods than are on 
WAGenericTag gets its own subclass of WATagBrush. If WAGenericTag is enough 
then it's gonna be WAGenericTag.

Original comment by philippe...@gmail.com on 22 Jan 2012 at 2:23

  • Added labels: Priority-Low, Seafox
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Hi Philippe,

I've just got round to fixing some bugs in Seafox - namely trying to work out 
why:

<section>
 <header>
  <h1>foo</h1>
 </header>
 <p>bar</p>
</section>

gets translated as:

"Unrecognised element 'section'"
(html tag: 'section') with:[
"Unrecognised element 'header'"
(html tag: 'header') with:[
html heading level: 1; with: 'foo' ].
html paragraph: 'bar' ]

The reason is that WAHtmlCanvas>>#section and WAHtmlCanvas>>#header have an 
extra space or rather a CR at the end of their string, for example:  self tag: 
'header '

I guess that this isn't deliberate. Would you like me to correct it and check 
in a fixed version? The effected tags are:

summary
header
section
footer

In the meantime I'll add a call to #withoutTrailingBlanks to Seafox htmlElements

Cheers

Original comment by philippe...@gmail.com on 24 Jan 2012 at 6:22

  • Changed title: HTML5 Tags don't have superfluous space
  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 24 Jan 2012 at 6:23

  • Changed title: HTML5 Tags have superfluous space
  • Added labels: Version-Seaside3.0
  • Removed labels: Seafox

@GoogleCodeExporter
Copy link
Author

Name: Seaside-HTML5-pmm.30
Author: pmm
Time: 24 January 2012, 7:24:43 am
UUID: a2ba133b-3076-4e57-9894-eb1d2f8afe4f
Ancestors: Seaside-HTML5-pmm.29

- Issue 701:    HTML5 Tags have superfluous space

Original comment by philippe...@gmail.com on 24 Jan 2012 at 6:26

  • Added labels: HTML5
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: Seaside-HTML5-pmm.28
Author: pmm
Time: 24 January 2012, 7:30:51 am
UUID: 75c03738-39b6-4138-8857-2fd11a8ebb32
Ancestors: Seaside-HTML5-NickAger.26

- Issue 701:    HTML5 Tags have superfluous space

Original comment by philippe...@gmail.com on 24 Jan 2012 at 6:31

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant