Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please give me back my arrow keys #382

Closed
GoogleCodeExporter opened this issue Mar 28, 2015 · 7 comments
Closed

Please give me back my arrow keys #382

GoogleCodeExporter opened this issue Mar 28, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

CL http://code.google.com/p/rietveld/source/detail?r=140baeb01745 added a 
feature that takes over the arrow keys to make them move the focus instead of 
scrolling.  I can see that some people might want this feature [I don't 
personally], but could you please switch to using some other keys?

Scrolling by arrow key is a cross-browser standard that's fundamental to how 
many of us navigate web pages.  Now if I want to scroll at a reasonable pace, 
or by a controlled amount, I need to use the mouse.  Before this I could just 
use my keyboard, which I much prefer.

What browser are you using?  What version? On what operating system?

I'm on Chrome 19.0.1084.41 beta on Linux at the moment.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)

https://chromiumcodereview.appspot.com

Original issue reported on code.google.com by ericu@chromium.org on 22 May 2012 at 9:57

@GoogleCodeExporter
Copy link
Author

I have to agree that something's not quite right with this feature.  The way we 
had it implemented in Mondrian, moving the blue marker down by one line would 
simultaneously scroll the window up the same amount.  But the way it's done now 
in Rietveld, the blue marker moves all the way to the top or bottom of the 
window before scrolling occurs, and then it jumps by almost a whole page.  
Also, I find that in Firefox (FF 12.0 on Linux at least) the page up/down keys 
have stopped working.

Andi, can you revisit this?  I think that some previous recent complaints about 
the blue marker also had to do with this -- I'd forgotten that there was a 
functionality change.  Or perhaps something else more recently made it worse??? 
 I don't recall noticing this during the review.

Original comment by guido@google.com on 22 May 2012 at 10:23

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

If the screen still scrolled as normal, I certainly wouldn't mind that the 
marker moved in the opposite direction.

Original comment by ericu@chromium.org on 22 May 2012 at 10:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Agreed, this came up so often in the last few weeks, I'll have a look at it 
ASAP.

Original comment by albrecht.andi on 23 May 2012 at 6:56

  • Added labels: Component-UI
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I've uploaded a modified version that scrolls immediately to my test instance: 
See for example http://rvtests.appspot.com/73842/diff/1/upload.py

Is this behavior better?

Original comment by albrecht.andi on 23 May 2012 at 8:10

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Yes, it's much better.
It's a significantly slower scroll than a normal web page, which is a little 
odd, but I can deal with that.

Thanks!

Original comment by ericu@chromium.org on 23 May 2012 at 3:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Review: http://codereview.appspot.com/6221068

Original comment by albrecht.andi on 23 May 2012 at 7:15

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision d86fc9600d63.

Original comment by albrecht.andi on 24 May 2012 at 6:25

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant