Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename vlan_tx_tag* calls to skb_vlan_tag* for Linux 4.0.0 #1

Closed
wants to merge 2 commits into from
Closed

Rename vlan_tx_tag* calls to skb_vlan_tag* for Linux 4.0.0 #1

wants to merge 2 commits into from

Conversation

chtitux
Copy link

@chtitux chtitux commented Mar 25, 2015

The commit in torvalds/linux@df8a39d has renamed some net functions, so if you encounter such error while compiling the driver with linux-4.0.0 or upper :

  CC [M]  /root/network/r8168/src/r8168_n.o
/root/network/r8168/src/r8168_n.c: In function ‘rtl8168_tx_vlan_tag’:
/root/network/r8168/src/r8168_n.c:3295:9: error: implicit declaration of function ‘vlan_tx_tag_present’ [-Werror=implicit-function-declaration]
         tag = (vlan_tx_tag_present(skb)) ?
         ^
/root/network/r8168/src/r8168_n.c:3296:15: error: implicit declaration of function ‘vlan_tx_tag_get’ [-Werror=implicit-function-declaration]
               TxVlanTag | swab16(vlan_tx_tag_get(skb)) : 0x00;
               ^
cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target '/root/network/r8168/src/r8168_n.o' failed

you can simply apply this patch and try to recompile.

PS : I know this repository is simply a mirror, but I wanted to share the patch.

@mtorromeo
Copy link
Owner

Thanks, it may come in handy

@mtorromeo
Copy link
Owner

This has been fixed in 8.040.00

@mtorromeo mtorromeo closed this May 26, 2015
@kryptoss kryptoss mentioned this pull request Jul 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chtitux @mtorromeo