Issue 147: Fixes for logging
Status:  Fixed
Owner:
Closed:  Dec 2008
Reported by michal@cihar.com, Dec 16, 2008
I encountered there are several problems with logging. Attached patch
addresses all these.

1. Config file errors are not reported as error messages and you have to
enable debug level to spot them.

2. LogEvent events are not logged because they arrive in a tuple to
observer and it does not expect it.

3. Exceptions while importing submodules are not logged unless in debug
level (this is caused by fact that this event is not caught as an
exception, but as a stderr output).
pyicqt.diff
1.7 KB   View   Download
Dec 18, 2008
Project Member #1 r000ns...@gmail.com
Applied with minor changes. Thanks!
Status: Fixed
Owner: r000nster
Labels: Milestone-0.8.1.1
Dec 18, 2008
#2 michal@cihar.com
Your patch looks to me a bit wrong - eventDict['message'] is usually either
(LogEvent, ) or ('one line', 'second line', 'third line'). The change in git does not
seem to properly handle the latter situation.

Dec 18, 2008
Project Member #3 r000ns...@gmail.com
Receiving of tuple by observer not causes exception. It shall write to log directly
as "('one line', 'second line', 'third line')"
Dec 18, 2008
#4 michal@cihar.com
You're right it works properly ... sorry for the mess.
Dec 18, 2008
Project Member #5 r000ns...@gmail.com
Don't worry about it