Issue 138: Buggy SOCKS5 Support
Status:  Fixed
Owner:
Closed:  Nov 2008
Reported by Master.N...@gmail.com, Apr 28, 2008
What steps will reproduce the problem?
1. Setup socksProxyServer & socksProxyPort
2. Try logon with pyicq-t

What is the expected output? What do you see instead?

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
48, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
33, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 37, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/epollreactor.py",
line 200, in _doReadOrWrite
    why = selectable.doWrite()
  File "/usr/local/lib/python2.5/site-packages/twisted/internet/tcp.py",
line 563, in doConnect
    self._connectDone()
  File "/usr/local/lib/python2.5/site-packages/twisted/internet/tcp.py",
line 568, in _connectDone
    self.protocol.makeConnection(self)
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/protocol.py", line
333, in makeConnection
    self.connectionMade()
  File "/srv/openfire/pyicq/src/tlib/socks5.py", line 78, in connectionMade
    log.debug ("SOCKS5.connectionMade")
exceptions.AttributeError: 'module' object has no attribute 'debug'
Traceback (most recent call last):
  File "/srv/openfire/pyicq/src/main.py", line 456, in main
    reactor.run()
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/posixbase.py",
line 220, in run
    self.mainLoop()
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/posixbase.py",
line 231, in mainLoop
    self.doIteration(t)
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/epollreactor.py",
line 181, in doPoll
    log.callWithLogger(selectable, _drdw, selectable, fd, event)
--- <exception caught here> ---
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
48, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
33, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 37, in callWithContext
    return func(*args,**kw)
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/epollreactor.py",
line 210, in _doReadOrWrite
    self._disconnectSelectable(selectable, why, inRead)
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/posixbase.py",
line 258, in _disconnectSelectable
    selectable.connectionLost(failure.Failure(why))
  File "/usr/local/lib/python2.5/site-packages/twisted/internet/tcp.py",
line 577, in connectionLost
    self.connector.connectionLost(reason)
  File "/usr/local/lib/python2.5/site-packages/twisted/internet/base.py",
line 704, in connectionLost
    self.factory.clientConnectionLost(self, reason)
  File "/srv/openfire/pyicq/src/tlib/socks5.py", line 372, in
clientConnectionLost
    self.otherFactory.clientConnectionFailed (connector, rmap)
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/protocol.py", line
155, in clientConnectionFailed
    self.reactor.callLater(0, self.deferred.errback, reason)
exceptions.AttributeError: _InstanceFactory instance has no attribute
'deferred'


If I comment all log.debug strings in socks5.py:

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
48, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/log.py", line
33, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/local/lib/python2.5/site-packages/twisted/python/context.py",
line 37, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File
"/usr/local/lib/python2.5/site-packages/twisted/internet/epollreactor.py",
line 197, in _doReadOrWrite
    why = selectable.doRead()
  File "/usr/local/lib/python2.5/site-packages/twisted/internet/tcp.py",
line 362, in doRead
    return self.protocol.dataReceived(data)
  File "/srv/openfire/pyicq/src/tlib/socks5.py", line 91, in dataReceived
    method (data)
  File "/srv/openfire/pyicq/src/tlib/socks5.py", line 202, in
socks_gotConnectReply
    self.otherProtocol.connectionMade()
  File "/srv/openfire/pyicq/src/tlib/oscar.py", line 607, in connectionMade
    self.transport.setTcpNoDelay(True)
exceptions.AttributeError: ClientProtocol instance has no attribute
'setTcpNoDelay'


What version of the product are you using? On what operating system?
PyICQ-t 0.8b, OpenSuSE 10.2

Please provide any additional information below.
Twisted-2.5.0.tar.bz2
TwistedWeb-0.7.0.tar.bz2
TwistedWords-0.5.0.tar.bz2
TwistedXish-0.1.0a4.tar.bz2
MySQL-python-1.2.2.tar.gz
Nevow-0.9.31.tar.gz
Openfire 3.51
Oct 31, 2008
Project Member #1 r000ns...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Owner: r000nster
Labels: Milestone-0.8.1b3
Nov 8, 2008
Project Member #2 r000ns...@gmail.com
(No comment was entered for this change.)
Status: Fixed