My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 74: Russian related patches
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  jadest...@gmail.com
Closed:  Jan 2008


 
Reported by jadest...@gmail.com, Dec 15, 2007
 Posted by maxbritov at 2007-07-10 08:39:13

There is troubles with russian icq messages like away and offline.
I think this issue place may be useful to collect patches fixing this.

Posted by maxbritov at 2007-07-10 08:48:14

Patch should fix aways, offline and new utf8 related issues.
Works for me. Patch from  issue 89 .

Posted by xfyre at 2007-07-10 16:09:37

Works great, thank you!

I've been waiting for this fix for a very long time.

Posted by maxbritov at 2007-07-12 13:49:30

Updated patch pyicq20070712.patch
*  Should work with twisted 2.5
    found here
http://osdir.com/ml/network.jabber.py-transports/2007-01/msg00008.html
*  Incorporated feature request 109
   
http://www.blathersource.org/features_view.php?projid=pyicq-t&featid=109

Posted by guest at 2007-07-12 19:52:02

-----------
_cbGetAway [2, 6, 0, 0, 47L,
'\t191495914\x00\x00\x00\t\x00\x01\x00\x02\x00q\x00\x0c\x00%\x00\x00\x00\x00\x00
\x00\x00\x00\x04\x00\x0b\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x03\x08\x00
\x02\x00\x00\x00\x00\x0e\x00\x00\x00\x0f\x00\x00\x00\n\x00\x04\x00\x00\x00\x00\x
00\x06\x00\x04\x10\x01\x00\x04\x00\x05\x00\x04@\xb9\xb3$\x00\r\x00\x90\tF\x13IL\
x7f\x11\xd1\x82"DEST\x00\x00\tF\x13CL\x7f\x11\xd1\x82"DEST\x00\x00\tF\
x13DL\x7f\x11\xd1\x82"DEST\x00\x00\tF\x13NL\x7f\x11\xd1\x82"DEST\x00\x
00\tF\x13LL\x7f\x11\xd1\x82"DEST\x00\x00V?\xc8\t\x0boA\xbd\x9fyB&\t\xdf
\xa2\xf3V?\xc8\t\x0boAQIP
2005a\xd3\xd4S\x19\x8b2@;\xac\xc7\xd1\xa9\xe2\xb5\x81>\x1a\t<l\xd7\xfdN\xc
5\x9dQ\xa6GN4\xf5\xa0\x00\x04\x00\x02\x00\x1a\x00\x0f\x00\x04\x00\x00\x06\x86\x0
0\x03\x00\x04F\x96{\x1a']

[2007-07-12 23:31:43] INFO :: green@gelf.no-ip.org :: icqt.B ::
sendAwayPresence
:: {'status': u'\x00\x1a', 'c': <contact.Contact instance at 0x84d00ec>,
'show': 'xa', 'url': '', 'buddyjid': '191495914@icq.gelf.no-ip.org', 'charset':
'windows-1251', 'm': None, 'ptype': None, 'user': <OSCARUser 191495914, flags
['unconfirmed', 'free', 'away', 'icq'], online for 27 minutes, idle for 26
minutes, caps ['icq5unknown1', 'icq_direct', 'sendfile', 'serv_rel',
'unicode']>, 'msg': ['F\x96{\x1a', '\x00\x1a'], 'icq2jid': <function
icq2jid at 0x85f3ed4>} :: Away broken (windows-1251, s) message s
----------
in jabber - broken, in icq-client this - _not_ broken away.

Posted by maxbritov at 2007-07-13 16:20:35

2guest: I had many tracebacks here. And I doesn't want learn icq protocol :)
/me just fix tracebacks in logs :)

Posted by guest at 2007-07-13 17:34:51

i just want to ask, how to view this "broken away" in russian
codepage?

http://img104.imageshack.us/my.php?image=10891085108010841086108qj9.png
(49Kb)

Posted by maxbritov at 2007-07-13 18:13:31

2 guest:

Please compare broken away like you show:

[2007-07-13 20:40:06] _cbGetAway [2, 6, 0, 0, 93L,
'\x011223344\x00\x00\x00\n\x00\x01\x00\x02\x00p\x00\x0c\x00%\x00\x00\x00\x00\x00
\x00\x00\x00\x04\x00\t\x00\x00\x00\x00\x00\x00\x00P\x00\x00\x00\x03Bb\x80\xacF\x
97^\x0f@\xec>L\x00\x00\x00\n\x00\x04\x00\x00\x00\x00\x00\x06\x00\x04
\x00\x00\x01\x00\x05\x00\x049\xc8\xa6\x03\x00\r\x00p\tF\x13LL\x7f\x11\xd1\x82&qu
ot;DEST\x00\x00\tF\x13DL\x7f\x11\xd1\x82"DEST\x00\x00\tF\x13IL\x7f\x11\xd1\
x82"DEST\x00\x00\x1a\t<l\xd7\xfdN\xc5\x9dQ\xa6GN4\xf5\xa0\tF\x13NL\x7f\x
11\xd1\x82"DEST\x00\x00V?\xc8\t\x0boA\xbd\x9fyB&\t\xdf\xa2\xf3SIM
client 
\x00\t\x05\x80\x00\x1d\x00\x14\x00\x01\x01\x10\x9bk\xa6Z\xb43<\xdb\x8b\xd25\x
80?\xdc5I\x00\x04\x00\x02\x00\x00\x00\x0f\x00\x04\x00\x00(\x18\x00\x03\x00\x04F\
x97\x90\xde']
[2007-07-13 20:40:06] mxx1: F<97><90>Þ
[2007-07-13 20:40:06] mxx last status1: ^@^@
Here mxx is log.msg("mxx1: %s" % msg[0]) in legacy/icqt.py and 2nd
string is status

and:

[2007-07-13 20:38:07] _cbGetAway [2, 6, 0, 0, 92L,
'\t11223344\x00\x00\x00\n\x00\x01\x00\x02\x00p\x00\x0c\x00%\x00\x00\x00\x00\x00\
x00\x00\x00\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\n\x00\x04\x00\x00\x00\x00\x0
0\x06\x00\x04\x10\x02\x00\x01\x00\x05\x00\x04>\xc0\xb1\xff\x00\r\x00P\tF\x13C
L\x7f\x11\xd1\x82"DEST\x00\x00\tF\x13EL\x7f\x11\xd1\x82"DEST\x00\x00\t
F\x13FL\x7f\x11\xd1\x82"DEST\x00\x00\tF\x13NL\x7f\x11\xd1\x82"DEST\x00
\x00t\x8f$
b\x87\x11\xd1\x82"DEST\x00\x00\x00\'\x00\x04F\x97\x7f\xeb\x00\x0f\x00\x04\x
00\x00s\x03\x00\x03\x00\x04F\x97E|\x00\'\x00\x04F\x97\x7f\xeb\x00\x03\x00"t
ext/aolrtf;
charset="unicode-2-0"\x00\x04\x00~\x00<\x00h\x00t\x00m\x00l\x00>
\x00<\x00b\x00o\x00d\x00y\x00>\x00<\x00f\x00o\x00n\x00t\x00
\x00a\x00b\x00s\x00z\x00=\x000\x00
\x00s\x00i\x00z\x00e\x00=\x001\x00>\x04\x1e\x04B\x04A\x04C\x04B\x04A\x04B\x04
2\x04C\x04N\x00<\x00/\x00f\x00o\x00n\x00t\x00>\x00<\x00/\x00b\x00o\x00d
\x00y\x00>\x00<\x00/\x00h\x00t\x00m\x00l\x00>']
[2007-07-13 20:38:07] mxx1: text/aolrtf; charset="unicode-2-0"
[2007-07-13 20:38:07] mxx last status1: ...
Here in mxxlast status i have long utf-16be away string.

You will see secong away and you will see broken away on first string.
I doesn't know details about it. I will prefer remove broken status and left
English text only.
You see on screenshot: status concatenation with:
idle_time = "Idle %d hours"%(user.idleTime/(60))

IMHO ;)

Posted by maxbritov at 2007-07-25 12:13:52

Updated patch:
1. Added "+ patchcyr" to reported version
2. Workaround for broken away. Trying to ignore it.

Apply: cd src/ ; patch -p1 < pyicq20070725.patch

Posted by maxbritov at 2007-07-26 15:47:21

20070726: Merged patch from bug
http://www.blathersource.org/bugs_view.php?projid=pyicq-t&bugid=281

Posted by maxbritov at 2007-08-07 13:10:15

20070807: Added correct uptime on iq:last query

Posted by Z_God at 2007-08-10 00:35:25

Here is a fix for the problem where new buddies couldn't be added anymore.

This patch should be applied after pyicq20070807.patch.

Posted by maxbritov at 2007-08-23 12:02:21

updated patch:
- Commit Z_God's patch;
- Fixed date for jabber:iq:time;
- Fix for #329.

Posted by guest at 2007-08-28 20:39:27

Can you add this patch:

http://www.blathersource.org/bugs_view.php?projid=pyicq-t&bugid=329

?

Posted by maxbritov at 2007-08-29 06:33:45

should be in 23082007

Posted by guest at 2007-10-09 12:34:36

After this pyicq20070823.patch the transport loses all timestamp info from
offline messages. they come with no time at all :(



pyicq20070712.patch
8.1 KB   View   Download
pyicq20070725.patch
9.6 KB   View   Download
pyicq20070726.patch
10.2 KB   View   Download
pyicq20070807.patch
12.4 KB   View   Download
pyicq20070823.patch
12.0 KB   View   Download
pyicqcyr.patch
3.7 KB   View   Download
pyicq-oscar.py-fix-after-mbp.patch
1.2 KB   View   Download
Jan 14, 2008
#1 maxim.br...@gmail.com
I updated patchset for current svn231 (draft).
Additionally here removed twistfix (i'm using words from twisted 2.5) and removed web
interface.
pyicq20080114.patch
10.1 KB   View   Download
Jan 15, 2008
#2 maxim.br...@gmail.com
updated
pyicq20080115.patch
9.8 KB   View   Download
Jan 17, 2008
#3 A.N.Skov...@gmail.com
pyicq 231 + 20080115.patch - away not always ok :-\
screenshot attached
mir.JPG
31.6 KB   View   Download
Jan 19, 2008
Project Member #4 d...@jabber.fsinf.de
Committed most of pyicq20080115.patch in revision 234. Please open new tickets if
needed. Please try to provide individual patches for individual issues.
Status: Fixed

Powered by Google Project Hosting