My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 50: more than one <error/> child in errors
  Back to list
Status:  Fixed
Owner:  jadest...@gmail.com
Closed:  Jan 2008


 
Reported by jadest...@gmail.com, Dec 9, 2007
 Posted by guest at 2006-11-08 10:00:15

It seems that pyicqt is adding multiple error childs.

A user who is not registered with the transport sent three messages to some icq
#. 
The first error message is ok:
<message from='fool@myhost/tn' to='somenumber@icq'
type='chat'><body>test1</body></message>
<message to='fool@myhost/tn' from='somenumber@icq' type='error'>
    <error code='401' type='auth'>
        <not-authorized xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
        <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler. Sie
m..ssen sich erst beim Transport anmelden bevor Nachrichten versendet werden
k..nnen.</text>
    </error>
    <body>test1</body>
</message>

The second one contains the error and body childs from the first error:
<message from='fool@myhost/tn' to='somenumber@icq'
type='chat'><body>test2</body></message>
<message to='fool@myhost/tn' from='somenumber@icq' type='error'>          
                                        <error code='401' type='auth'>    
                                                                               
<not-authorized xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>             
                                    <text
xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler. Sie m..ssen sich erst
beim Transport anmelden bevor Nachrichten versendet werden k..nnen.</text>
                                                               </error>   
                                                                          
     
                  <body>test1</body>                                
                                                            <error code='401'
type='auth'>                                                                 
                   <not-authorized
xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>                                
                 <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler.
Sie m..ssen sich erst beim Transport anmelden bevor Nachrichten versendet
werden
k..nnen.</text>
    </error>
    <body>test2</body>
</message>

and the third contains all the errors from messages 1 + 2:
<message from='fool@myhost/tn' to='somenumber@icq'
type='chat'><body>test3</body></message>
<message to='fool@myhost/tn' from='somenumber@icq' type='error'>          
                                        <error code='401' type='auth'>    
                                                                               
<not-authorized xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>             
                                    <text
xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler. Sie m..ssen sich erst
beim Transport anmelden bevor Nachrichten versendet werden k..nnen.</text>
                                                               </error>   
                                                                          
     
                  <body>test1</body>                                
                                                            <error code='401'
type='auth'>
        <not-authorized xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
        <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler. Sie
m..ssen sich erst beim Transport anmelden bevor Nachrichten versendet werden
k..nnen.</text>
    </error>
    <body>test2</body>
    <error code='401' type='auth'>
        <not-authorized xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
        <text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Fehler. Sie
m..ssen sich erst beim Transport anmelden bevor Nachrichten versendet werden
k..nnen.</text>
    </error>
    <body>test3</body>
</message>

Version is from SVN, Last Updated: 2006-09-28 14:19:12 +0200 (Thu, 28 Sep 2006)

Posted by guest at 2006-11-08 10:25:30

This also happens if another user sends the second message, disclosing what the
first user sent.

Posted by guest at 2006-11-12 20:18:33

http://hancke.name/jabber/doubleerror.patch fixes this bug. 

Currently, sendErrorMessage uses ONE shared element (check id(el)), which
causes
the bugs described above.

Python gotchas... ;-)


Jan 19, 2008
Project Member #1 d...@jabber.fsinf.de
Fixed in revision 234.
Status: Fixed

Powered by Google Project Hosting