Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails to compile on mips and probably other archs #83

Closed
rofl0r opened this issue Nov 15, 2014 · 3 comments
Closed

fails to compile on mips and probably other archs #83

rofl0r opened this issue Nov 15, 2014 · 3 comments

Comments

@rofl0r
Copy link

rofl0r commented Nov 15, 2014 

./google/protobuf/stubs/platform_macros.h:61:2:
 #error Host architecture was not detected as supported by protobuf

sabotage-linux/sabotage#250

why? there should be a portable fallback for platforms that are not "zomg asm optimized"
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Nov 24, 2014

We don't have resource to test it on these platforms. If you know how to implement a portable fallback (or how to make platform_macros.h to support your platform, you are welcome to send a patch for that.

@edmonds
Copy link
Contributor

edmonds commented Nov 25, 2014

If https://github.com/sabotage-linux/sabotage/blob/master/pkg/protobuf is correct, this is a report against protobuf 2.5.0, which pre-dates the generic architecture support in protobuf >= 2.6.0.

@rofl0r
Copy link
Author

rofl0r commented Nov 25, 2014

yay, that's good news. it seems to work at least on mips now.

@rofl0r rofl0r closed this as completed Nov 25, 2014
TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
@haberman
Merge pull request protocolbuffers#83 from TeBoring/master
04fcf0b 
Add new file option php_namespace.
@smartnet-club smartnet-club mentioned this issue Jan 13, 2020
Closed
bithium pushed a commit to bithium/protobuf that referenced this issue Sep 4, 2023
@haberman
Merge pull request protocolbuffers#83 from TeBoring/master
9f6245e 
Add new file option php_namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edmonds @rofl0r @xfxyjwf