C# conformance tests #689
C# conformance tests #689
Conversation
jskeet
force-pushed
the
fix-eof
branch
2 times, most recently
from
e2a8a35
to
101dd04
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
jskeet
force-pushed
the
fix-eof
branch
3 times, most recently
from
eb0a204
to
be9c18a
Compare
|
CLAs look good, thanks! |
|
|
||
| private static bool RunTest(BinaryReader input, BinaryWriter output) | ||
| { | ||
| int? size = ReadInt32(input); |
There was a problem hiding this comment.
Nope - that would throw if we reached the end of the input. If we could detect whether we were at the end of the stream, we could test for that and then call ReadInt32 or ReadUInt32, but we can't do so easily :(
|
Looks great, thanks for doing this! |
|
I'm very glad I did - it found two significant bugs! |
|
LGTM after addressing the one small comment. Thanks for implementing this and good job catching the bugs. |
Completely untested so far - easier to get started in VS and then transfer to Linux for tweaking...
The tests are run from Travis in the same way as on other platforms. Currently some expected failures - but only expected in that they're what we got to start with. Will try to fix them in other pull requests.
This is expected to be the cause of the conformance test failures. Generated code in next commit.
…s we expected to. We should now have no conformance failures.
|
Merging as only change since last "green" was in AssemblyInfo which wouldn't affect other builds, and the C# build is green. |
I had this in two separate branches, but I fail at git, so I've introduced the tests and fixed them in the same PR.
In short: