Optimize CodedInputStream.readByteBuffer() for LiteralByteString #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch applied `CodedInputStream.readByteBuffer()` returns `ByteBuffer` wrapping array contained in `LiteralByteString`. To ensure that `LiteralByteString` is not modified, returned buffer is made readonly with `.asReadOnlyBuffer()` operation.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! (as stepan.koltsov@gmail.com) |
|
CLAs look good, thanks! |
xfxyjwf
reviewed
Jun 23, 2018
| ByteBuffer result; | ||
| if (input == null && enableAliasing) { | ||
| if (bufferIsImmutable) { | ||
| result = ByteBuffer.wrap(buffer, bufferPos, size).asReadOnlyBuffer().slice(); |
There was a problem hiding this comment.
This is an API breaking change. readByteBuffer() should return a mutable buffer, not a read-only one.
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch applied
CodedInputStream.readByteBuffer()returnsByteBufferwrapping array contained inLiteralByteString. Toensure that
LiteralByteStringis not modified, returned bufferis made readonly with
.asReadOnlyBuffer()operation.