Add ReleaseSigned configuration for C# #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
changed the title
|
I believe I addressed all the comments from #657. |
|
Okay, looks good - but we should review everything around version numbers before we create and push a NuGet package. |
jskeet
added a commit
that referenced
this pull request
Aug 3, 2015
Add ReleaseSigned configuration for C#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated #657 against master.
-- add build configuration ReleaseSigned which builds signed assemblies
-- update nuspec file to use signed assemblies.
-- added protoc.exe and well known proto files to tools/ directory in nuget package.
-- some additional nits.
fixes #608