Port python bindings to Python 3 #66

Kentzo · 2014-10-27T02:30:27Z

Here I'm going to address remaining issues by merging changes from my diverged fork that made Protobuf 2.5.1 compatible with Python 3 by retaining compatibility with all other supported versions.

I kindly ask authorized developers to review and leave comments and I'll try to address them as soon as I can.

A few questions:

Did you loose the requirements for minimum Python 2 version?
Most tests are missing here: https://github.com/GreatFruitOmsk/protobuf/blob/master/python/setup.py#L100-L102. Why?

xfxyjwf · 2014-10-27T16:57:53Z

+ @mrovner to help take a look.

tseaver · 2014-11-18T15:11:06Z

python/ez_setup.py

+  return _install(tarball, _build_install_args(options))
+
+if __name__ == '__main__':
+  sys.exit(main())


+1. Replacing the old, Python2-only 'ez_setup.py' with one from the setuptools bitbucket repo is definitely the Right Thing. FTR, the permalink for "latest and greatest" ez_setup.py is: https://bootstrap.pypa.io/ez_setup.py

tseaver · 2014-11-18T15:50:37Z

python/google/protobuf/internal/reflection_test.py

+    #The first input has to be a string, and literals are unicode
+    MyProtoClass = reflection.GeneratedProtocolMessageType(str('MyProtoClass'),
+                                                           (message.Message,),
+                                                           {'DESCRIPTOR': mydescriptor})


Is this change related to the Python3 port, or is it just ensuring better coverage of what the testcase name says it is about?

Kentzo · 2014-11-18T16:53:50Z

@xfxyjwf @mrovner Do we still need to support Python 2.5 in protobuf 2.6+ ?

mrovner · 2014-11-18T16:59:07Z

Yes, we still have 2.5 clients.

On Tue, Nov 18, 2014 at 8:53 AM, Ilya Kulakov notifications@github.com
wrote:

@xfxyjwf https://github.com/xfxyjwf @mrovner
https://github.com/mrovner Do we still need to support Python 2.6 in
protobuf 2.6+ ?

—
Reply to this email directly or view it on GitHub
#66 (comment).

Thanks,
--Mike

Kentzo · 2014-11-18T17:00:08Z

@tseaver Please edit your reviews given that answer :)

tseaver · 2014-11-18T17:03:12Z

@mrovner I thought the question was about keeping 2.6 support: are you saying that we need to ship a protobuf that spans 2.5 through 3.4?

Would bumping a major version to signal dropping 2.5 support while adding 3.x support be reasonable? Users stuck on Python 2.5 would then stay with protobuf 2.6.x, while those who needed Py3k could move to protobuf 2.7.x.

virtuald · 2014-11-21T04:16:06Z

python/google/protobuf/internal/cpp_message.py

@@ -610,7 +624,10 @@ def FindInitializationErrors(self):
    return self._cmsg.FindInitializationErrors()

  def __str__(self):
-    return str(self._cmsg)
+    if PY2:


Might make more sense to move this block up to line 44, instead of having the if statement down here.

sebastianludwig · 2014-12-15T17:07:04Z

Is there any way to support this pull request?

tseaver · 2014-12-15T17:32:19Z

I note that the master is no aiming at a 3.0.0 release: that would seem like an ideal time to drop support for Python < 2.6.

tseaver · 2014-12-15T17:50:02Z

python/setup.py

@@ -172,6 +172,7 @@ def run(self):
          'google.protobuf.internal.message_listener',
          'google.protobuf.internal.python_message',
          'google.protobuf.internal.type_checkers',
+          'google.protobuf.internal.utils',


Given that we rely on setuptools (boostrapping from ez_setup.py if it isn't present), we should be able to use its find_packages() rather than enumerating modules by hand.

davidB · 2014-12-20T22:08:15Z

Hi,

Until support of python, I share my workaround, a script to convert to python3:

# more info at http://python3porting.com/bookindex.html
# download protobuf-2.6.1.tar.gz for python
cd modules
rm -Rf google
tar -xzvf ~/Téléchargements/protobuf-2.6.1.tar.gz protobuf-2.6.1/google
2to3-3.4 protobuf-2.6.1/google -o google -W --no-diffs -p -n
rm -Rf protobuf-2.6.1

2to3 is a tool provide by python3.
I used it be able to use protobuf with bendler (blender 2.72 include python 3.4.2)

Kentzo · 2015-01-06T20:30:15Z

@mrovner I believe this PR can be closed without merging. Please confirm.

tamird · 2015-05-15T22:57:48Z

@Kentzo protobuf now officially doesn't need to support python 2.5 and 2.6. Would you like to rebase this such that only 2.7+ is supported?

Kentzo · 2015-05-21T20:11:26Z

@tamird I don't have time to review that right now. We don't plan to migrate to 2.6 anytime soon.

Any help is welcome :)

tamird · 2015-08-22T17:15:02Z

@haberman probably time to close this guy :)

haberman · 2016-02-16T23:36:55Z

Ah yes, this has been addressed in other changes. Closing now.

Fix email links

Kentzo force-pushed the master branch from 53db375 to b9ab66f Compare October 27, 2014 02:32

Kentzo changed the title ~~Port Protobuf to work under Python 3~~ Port python bindings to Python 3 Oct 27, 2014

Make setup.py/ez_setup.py runnable under Python 3.

1c0d421

Kentzo force-pushed the master branch from b9ab66f to 1c0d421 Compare October 27, 2014 02:35

xfxyjwf assigned mrovner Oct 27, 2014

Kentzo added 7 commits October 28, 2014 23:27

Re-structure utils.py to simplify reading.

543ffb9

Make cpp_message and decoder python 3 compatible.

cbbbf08

Make python_generator python 3 compatible.

d91115a

Make encoder python 3 compatible.

3a32639

Make enum_type_wrapper python 3 compatible.

3552389

Make python message python 3 compatible.

0b69b26

Make reflection test python 3 compatible.

ae5c3d0

Kentzo mentioned this pull request Nov 8, 2014

setup.py fixes for Python 3 #50

Merged

tseaver mentioned this pull request Nov 18, 2014

Protobuf 2.6.0 incompatibility issues with Python 3.x #7

Closed

tseaver reviewed Nov 18, 2014
View reviewed changes

virtuald reviewed Nov 21, 2014
View reviewed changes

tseaver mentioned this pull request Nov 24, 2014

Ensure Python 3 support googleapis/google-cloud-python#91

Closed

tseaver reviewed Dec 15, 2014
View reviewed changes

googlebot added the cla: yes label Jan 6, 2015

tseaver mentioned this pull request Jan 13, 2015

Prepare for Python2-Python3 straddle. #164

Merged

haberman mentioned this pull request Jul 28, 2015

Status of Python 3 (3.4+) support? #646

Closed

haberman closed this Feb 16, 2016

google-admin unassigned mrovner Aug 21, 2018

TeBoring pushed a commit to TeBoring/protobuf that referenced this pull request Jan 19, 2019

Merge pull request protocolbuffers#66 from mortonfox/patch-1

dfc4096

Fix email links

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port python bindings to Python 3 #66

Port python bindings to Python 3 #66

Kentzo commented Oct 27, 2014

xfxyjwf commented Oct 27, 2014

tseaver Nov 18, 2014

tseaver Nov 18, 2014

Kentzo commented Nov 18, 2014

mrovner commented Nov 18, 2014

Kentzo commented Nov 18, 2014

tseaver commented Nov 18, 2014

virtuald Nov 21, 2014

sebastianludwig commented Dec 15, 2014

tseaver commented Dec 15, 2014

tseaver Dec 15, 2014

davidB commented Dec 20, 2014

Kentzo commented Jan 6, 2015

tamird commented May 15, 2015

Kentzo commented May 21, 2015

tamird commented Aug 22, 2015

haberman commented Feb 16, 2016

Port python bindings to Python 3 #66

Port python bindings to Python 3 #66

Conversation

Kentzo commented Oct 27, 2014

xfxyjwf commented Oct 27, 2014

tseaver Nov 18, 2014

Choose a reason for hiding this comment

tseaver Nov 18, 2014

Choose a reason for hiding this comment

Kentzo commented Nov 18, 2014

mrovner commented Nov 18, 2014

Kentzo commented Nov 18, 2014

tseaver commented Nov 18, 2014

virtuald Nov 21, 2014

Choose a reason for hiding this comment

sebastianludwig commented Dec 15, 2014

tseaver commented Dec 15, 2014

tseaver Dec 15, 2014

Choose a reason for hiding this comment

davidB commented Dec 20, 2014

Kentzo commented Jan 6, 2015

tamird commented May 15, 2015

Kentzo commented May 21, 2015

tamird commented Aug 22, 2015

haberman commented Feb 16, 2016