Remove the C# Freeze API #654
Conversation
jtattermusch
force-pushed
the
csharp_hide_freeze
branch
from
c686a8d
to
7ec023a
Compare
|
LGTM so far, although I'd probably have gone further. Merging, and we can work out whether to remove more later (but not much later). |
|
As a curiosity, is this change permanent? The mutability of messages has bit my team few times. I'd be interested in seeing the reasoning for removing it. |
|
Yes, I'd be very surprised if we reimplemented Freeze at this point. |
|
I would also like to see immutability come back some time since it would fit our needs better and would fit better with the other platforms. |
|
@Falco20019: I think at this point it would make more sense to have an entirely separate generator (and support library) for immutable protobufs. I'm glad we removed Freeze - it's a pain working with types that might be immutable or might not be. |
Based on the pushback in the API review, I think the best thing to do is to remove the Freeze API for now (as requested by @pherl).
We can reintroduce this once we reach decision if we should support Freeze or not. Reverting this change should be easy, applying an inverted diff and regenerating code is pretty straightforward.