Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc should not convert .proto's default values in the resulted FileDescriptorProto #61

Closed
protobufel opened this issue Oct 21, 2014 · 0 comments
Labels

Comments

@protobufel
Copy link

As per spec and to retain FileDescriptorProto's canonical nature, protoc should validate, but not make the FieldDescriptorProto's default value different form the original proto. Also, in Java if one manually creates FileDescriptorProto, its defaults are not changed. Different languages do the conversion of the defaults differently, so the produced/serialized protos will be different.

In addition, to make things more canonical/compatible across different language realms, it makes things easier, easier/faster to process, and much easier to implement/maintain.

@xfxyjwf xfxyjwf closed this as completed Jan 20, 2016
TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants