Could you help fix the issue in platform_macros.h? We don't work on Solaris machines and have to rely on our users to help fixing problems there.

I was thinking of how to fix this.. The problem is SOLARIS_64BIT_ENABLED is defined in config.h, and including config.h in platform_macros.h is not a good idea as it'll create macro names collisions with any other project including platform_macros.h or any other protobuf files that include it.

We had removed the use of config.h as it doesn't fit into the bazel build system. Is there any other predefined macros we can use here to distinguish between 64bit and 32bit on Solaris?

You can check for 64-bit on Solaris:
#if defined(sparc_v9) || defined(sparcv9) || defined(__arch64)

But you gotta get rid of the --enable-64bit-solaris flag as it won't make sense anymore

Thanks. That seems to be the way to go. Could you send a PR for this?

Sure. So to avoid breaking any existing auto build scripts that provide this --enable-64bit-solaris configure flag, should i just add a note saying it's deprecated and ignored?

It seems --enable-64bit-solaris does more than just adding the SOLARIS_64BIT_ENABLED macro (it adds -m64 to the C++ compiler arguments)? If so we probably don't want to remove it from the configure files.

Yes i noticed that. There are a few issues with it though. It appends the -m64 flag to CXXFLAGS and CFLAGS only if they were not provided by the user (users can provide these flags for purposes other than building a 64/32 bit build). It also doesn't add the -m64 flag to the LDFLAGS. I'll fix these issues and submit a PR that will make the --enable-64bit-solaris flag work properly.

Do you require a CLA from contributors?

@meltahan yes. When you send the pull request, a @googlebot will check your CLA and give instructions if you haven't signed it yet.

Finally the CLA issues are resolved. I'll submit a PR soon.