Modified FindRubyTestDir to use GOOGLE_THIRD_PARTY_PROTOBUF #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a CL making the same change to our internal code base? |
|
I don't have access to your internal code base to check. I am building the protobuf library using Bazel, and it lives in //third_party/protobuf/ in my repo. Looks like that is the same place that it lives internally due to the existence of the GOOGLE_THIRD_PARTY_PROTOBUF macro. I have found that macro very handy in getting ruby tests to run. |
|
@TeBoring , could you take a look at this PR? Did you need the same change in order to port alpha-3 to our internal code base? |
|
We don't use it internally. Internally, -Ithird_party/protobuf/src is add to copt. |
xfxyjwf
added a commit
that referenced
this pull request
Jun 15, 2015
Modified FindRubyTestDir to use GOOGLE_THIRD_PARTY_PROTOBUF
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Modified FindRubyTestDir to use GOOGLE_THIRD_PARTY_PROTOBUF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.