My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 4: Problem with If clause in grant_access_token that checks the expiry of the authcode
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Sep 2010


 
Reported by christop...@gmail.com, Aug 18, 2010
Hello and thanks for the great library!
In the Jul 19  version, in the file oauth.php line 452 and line 485 in the function grant_access_token():

if ($stored["expires"] > time())
$this->error(ERROR_BAD_REQUEST, ERROR_INVALID_GRANT);

I cannot understand why this isn't the other way around, 
if ($stored["expires"] < time()) 
Shouldn't the access token be denied if the current timestamp is greater than the auth code expiry timestamp?


Sep 4, 2010
Project Member #1 aaron.parecki
Thanks for reporting this. It was fixed in the August 3rd commit, but the libraries in the example folders were not updated correspondingly. They are now all up to date in revision 969fd139d1.
Status: Fixed

Powered by Google Project Hosting