| Issue 455: | the 'ajax' setting is not working with $.nyroModalManual(); | |
| 5 people starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem?
1. call nyroModalManual this way and it will throw an error:
$.nyroModalManual({url : 'your url', ajax {dataType : 'script'}});
2. you'll see it works fine if you call it like this:
$.nyroModalSettings({ajax {dataType : 'script'}});
$.nyroModalManual({url : 'your url'});
What is the expected output? What do you see instead?
The popup gets opened, but I get the following error in firebug console: $.ajax is not a function
Line 517
What version of the product are you using? On what operating system?
nyroModal 1.6.2, jQuery 1.4.2, Ubuntu 9.10
Please provide any additional information below.
I suppose the error is produced by line 341 in the nyroModal script:
callingSettings = $.extend(true, settings);
It seems to override the jQuery object's properties instead of
callingSettings' ones, so the $.ajax function becomes what I pass as 'ajax'
to the $.nyromodalManual parameters. If I'm not wrong, it's supposed to
extend the ajax settings, but not the function itself.
Here is my fix for this issue (line 341):
callingSettings = $.extend(callingSettings, settings);
Apr 3, 2010
#1
carljoha...@gmail.com
Apr 17, 2010
(No comment was entered for this change.)
Status:
Duplicate
Mergedinto: 433 |