My favorites | Sign in
Project Home Downloads Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 444: iFrame Throws Javascript Warning/Error if location includes https
2 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


 
Reported by intra...@lfcc.edu, Mar 9, 2010
What steps will reproduce the problem?
1. Create a nyroModal link that leads to an external domain with the https 
protocol (for instance, create an iFrame that leads to 
https://twitter.com/)
2. Click that link in your browser (I have tested in Chrome and IE8)

What is the expected output? What do you see instead?
I expect the iFrame to load in the modal window without any errors. 
Instead, in Chrome, the developer console gives me a warning about "unsafe 
javascript" and IE throws an error saying that something was "forbidden."

What version of the product are you using? On what operating system?
I have tested nyroModal 1.6.1 and 1.6.2 on Windows Vista Business x64.

Please provide any additional information below.
It appears that the problem is related to the following line of code from 
~line 1370 in the source code of 1.6.1 and around line 1374 in the source 
code for 1.6.2:

		if ((window.location.hostname && 
currentSettings.url.indexOf(window.location.hostname) > -1)
				||	
currentSettings.url.indexOf('http://') {


The line should probably read:

		if ((window.location.hostname && 
currentSettings.url.indexOf(window.location.hostname) > -1)
				||	
(currentSettings.url.indexOf('http://' && 
currentSettings.url.indexOf('https://')) {

Apr 17, 2010
Project Member #1 nyro...@gmail.com
Thanks for your bug fix.
It will be included in the next release.
If you have a blog or a website, I'll be glad to link it in the changelog.
Status: Accepted
Apr 19, 2010
#2 intra...@lfcc.edu
Fantastic. Thank you for taking care of this.

My blog is located at http://www.htmlcenter.com/

Powered by Google Project Hosting