My favorites | Sign in
Project Home Downloads Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 437: for IE6, body height problem in short body content
3 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


 
Reported by smile.sm...@gmail.com, Feb 24, 2010
What steps will reproduce the problem?

1. create short body content with DOCTYPE XHTML 1.0
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
---
<body>
<div>
<a href="#test_modal" class="nyroModal">modal</a>
<div id="test_modal">test</div>
</div>
</body>
----
2. open modal.
3. nyroModalBg height is less than window height
 
What is the expected output? What do you see instead?
nyroModalBg height should be more equal than window height.

What version of the product are you using? On what operating system?
Win XP IE6

Please provide any additional information below.
line 682(v1.6.2)

var h = $(window).height()+'px';
if ($(window).height() >= body.outerHeight()) {
  h = body.outerHeight()+'px';
} else

should be

var h = body.outerHeight()+'px';
if ($(window).height() >= body.outerHeight()) {
  h = $(window).height()+'px';
} else

?

Apr 17, 2010
Project Member #1 nyro...@gmail.com
Thanks for your bug fix.
It will be included in the next release.
If you have a blog or a website, I'll be glad to link it in the changelog.
Status: Accepted
Apr 22, 2010
#2 cxj...@gmail.com
yes,I will report it,
the same question for me.
I hope it fix.

I change the code:
line:687
w += 'px';
				body.css({
					width: w,
					height: body.height()+'px',
					position: 'static',
					overflow: 'hidden'
				});
Aug 24, 2010
#6 bergm...@gmail.com
Ok, I found a similar bug, it may be related, my fix is to change the "showContentOrLoading" method, like so:

	function showContentOrLoading() {
		debug('showContentOrLoading');
		if (modal.ready && !modal.anim) {
			if (modal.dataReady) {
				if (modal.tmp.html()) {
					modal.anim = true;
					
					// BUGFIX: Must set Window scroll for IE6, as it sometimes scrolls weirdly.
					if (isIE6) {
						window.scrollTo(0, $('#nyroModalBg').offset().top );
					}
					
					if (modal.transition) {
...
Nov 9, 2010
#12 smit.jan...@gmail.com
Hi,
I use IE8 popup and my page direction is RTL
I fix the above code in my JS file(1.6.2), but my modal box not shown in center and started at center to "right"

In Chrome it is OK

please help
Thanks
Nov 13, 2010
Project Member #13 nyro...@gmail.com
the version 2 is almost ready. Give it a try: http://goo.gl/PjHdn

Hopefully ths bug won't happen again

Powered by Google Project Hosting