My favorites | Sign in
Project Home Downloads Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 433: Bug with jQuery 1.4.x
5 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


 
Reported by seungjun...@gmail.com, Feb 17, 2010
What steps will reproduce the problem?
1. in firebug, execute $.nyroModalManual({url:'demoSent.php',ajax:{}})

What is the expected output? What do you see instead?
Page does not loaded

What version of the product are you using? On what operating system?
jQuery 1.4.1, nyroModal 1.6.1, Firefox 3.6 on Windows 7

Please provide any additional information below.
Works fine with jQuery 1.3.2

The following code seems to be an error in
================================================
	function processModal(settings) {
...
		callingSettings = $.extend(true, settings);
...
================================================

Change is good following.
================================================
	function processModal(settings) {
...
		callingSettings = $.extend(false, settings);
...
================================================


Apr 17, 2010
Project Member #1 nyro...@gmail.com
The solution isn't to set false because here we want a deep copy of the settings: you
don't have to reset all CSS settings to change or add only one.
The solution is to write:
$.extend(true, callingSettings, settings);

I also review all extend call to make them right regarding the jQuery doc.

This fix will be included in the next release.
Status: Accepted
Apr 17, 2010
Project Member #2 nyro...@gmail.com
 Issue 446  has been merged into this issue.
Apr 17, 2010
Project Member #3 nyro...@gmail.com
 Issue 455  has been merged into this issue.
Aug 2, 2010
#4 anotherhero
Don't you mean
callingSettings = $.extend(true, {}, settings);

Otherwise it will extend the callingSettings with the settings. While in the old situation you assigned callingSettings with a copy of settings.

Powered by Google Project Hosting