My favorites | Sign in
Project Home Downloads Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 34: popup not working correctly when using nyroModalManual in Safari
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Jun 2008


 
Reported by edmon...@gmail.com, Jun 24, 2008
What steps will reproduce the problem?
1. create a hidden <div id="stuff"> with html you want to show in your nyro
modal window
2. have an <a href="#stuff" id="popup" class="nyroModal">
3. make javascript call $('popup').nyroModalManual(); on Safari, make sure
page is from a url that includes a port number

What is the expected output? What do you see instead?
expect to see the html of the hidden div in a modal window.  a modal window
does pop up, but contains the main page within the window.

What version of the product are you using? On what operating system?
1.2.4 on windows, using safari.


Please provide any additional information below.
I found this to be a bug in safari, where from.hostname and from.host data
seems to be reversed.  this is an obscure bug that only happens in Safari
when a port number is included.  The quick fix was to update line 573 from:
if (from.target.toLowerCase() == '_blank' || (from.hostname !=
window.location.hostname))
to:
if (from.target.toLowerCase() == '_blank' ||
(from.hostname.replace(/:\d*$/,'') != window.location.hostname))
 

Jun 24, 2008
Project Member #1 nyro...@gmail.com
I never heard about this bug in Safari.
I'll implement your fix in the next release.
Thanks!
Status: Fixed
Jun 24, 2008
Project Member #2 nyro...@gmail.com
Hey, If you have a website, I'll be glad to put a link in the changelog to thanks you.
Jun 25, 2008
#3 edmon...@gmail.com
I've submitted the issue to Apple as well, but don't know when they'll get around to
fixing it.

the occurrence of this bug is rare, since the majority of websites would not be
specifying a port number in the url and using safari to test (it was found during
internal testing when the app server is on a port other than 80).

thanks for the offer, but the website I'm working on is for a client and I am unable
to disclose.  thanks for providing such a useful plug-in though!

Powered by Google Project Hosting