| Issue 27: | Bug in ajax target url and current url comparison? | |
| 2 people starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem? 1. create <a href="http://www.example.com/sub/path#contentElementId" class="nyroModal">Link</a> on the root of www.example.com 2. include element with id contentElementId on the root of www.example.com What is the expected output? What do you see instead? Expected to see element with id contentElementId from http://www.example.com/sub/path loaded in the modal window. Instead modal loads with element that has id contentElementId from http://www.example.com (current page). What version of the product are you using? On what operating system? Tested on windows and mac firefox. Please provide any additional information below. Attached is my quick, dirty and just shortly tested fix to fileType method of plugin. I think instead of comparing the beginning of the target and current location urls one should be comparing whether they are exactly the same (without the hash). I have not tested whether this works as generic fix and whether it introduces some other problem(s), but it works as fix on the case I used this plugin on. Excuse me if I've somehow misunderstood the nature of the problem experienced with the plugin - I'm a js novice...
Jun 11, 2008
Project Member
#1
nyro...@gmail.com
Status:
Fixed
Jun 12, 2008
Great! And thank you for a great plugin - it's been a real time saver! :)
Jun 12, 2008
I just released the version 1.2.7 and tested all the possibility to be sure this time it works. |