| Issue 248: | Hidden div not found when loading in modal if base href is set | |
| 2 people starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem?
1. Implement the hidden div example
2. Add a base href tag to your page <base href="site-url"></base>
3. Click the link to display the modal
The result is an error modal which says the content is not available.
What seems to be happening here is that because the base href is added to
the url, nyroModal assumes that its not a div in the page DOM it needs to load.
A workaround for this that I am using at the moment is to modify the code
at the line:
if(req == currLoc)
to
if(req == currLoc || req = $('base').attr('href'))
I have not tested if this tweak will impact on the other uses of nyroModal
apart from loading iframe content where it seems to have no adverse effect.
In any case, thanks for the plugin - it is really excellent and by far my
favourite of the various modal scripts out there.
May 18, 2009
#1
molloy...@gmail.com
Jul 9, 2009
Sorry for the long delay! Your fix you'll be included in the next version.
Status:
Accepted
Jul 9, 2009
Great. Once again, great work on the plugin. I've used it extensively on http://www.lostandfoundpets.ie and it really enhances the UI.
Jul 17, 2009
the version 1.5.1 just released should fix this issue.
Status:
Fixed
Labels: Type-Defect |