| Issue 241: | Problem with rel Attribute, false interpretation as Gallery Group | |
| 2 people starred this issue and may be notified of changes. | Back to list |
|
What steps will reproduce the problem? 1. Create a template with several link-tags with rel attribute, e.g. rel="nofollow" 2. Create one link-tag with class="nyroModal" and rel="nofollow" 3. Click on the nyroModal item What is the expected output? What do you see instead? I want gallery items only to be recognized as those, if they have a nyroModal class. In the nyroModel div (clicked on nyroModel item before), you may now be able to click left / right to switch through the apperently other gallery items. Please use labels and text to provide additional information. Maybe it was intended to be so, otherwise a fix would be cool.
May 13, 2009
Project Member
#1
nyro...@gmail.com
Status:
Fixed
May 14, 2009
After a while, the version 1.5.0 is now here and fix this issue.
May 14, 2009
Hi, thanks so far. - To be more precise, it is not quite the Problem of rel="nofollow" misinterpretation. The Problem is this: <a href="file.jpg" class="nyroModal" rel="external"><img src="file1.jpg" /></a> <a href="file.pdf" rel="external">PDF Document</a> <a href="http://xyz/ rel="external nofollow">Weblink</a> The Modal now shows me the Title "1/2" - this is my Problem. If I change the rel of the PDF to something like: rel="external noindex" it still shows the title in the ModalDiv of how many Gallery Items there are "1/1". Can one hide this information - otherwise if will fall back to 1.4.2 ;)
May 14, 2009
I see.
Instead of doing
> $('rel="galleryName"')
I'll do
> $('rel*="galleryName"')
which means you'll have to be careful if you want to set multiple galery.
For exemple, this link would also match:
<a rel="mygalleryName yeah">Anothoer gallery</a>
Moreover, I will write some code to extract the first word defined in the rel attribute.
On your exemple, rel="external nofollow" would be treated as the gallery 'external'
for searching the others links.
These 2 fixes would get out the trouble, right?
May 14, 2009
Why don't you check a combination of class and rel attribute, like:
$(".nyroModal[rel*='galleryName']")
This wouldn't find all tags which have the same rel attribute als galery items, but
only those which also have the nyroModal class.
- Or do you want to find all of the same relations, although there's no nyroModal
class provided?
May 14, 2009
I absolutely agree that rel="galleryName" and rel="galleryName yeah" are treated as the same gallery "galleryName". I am not quite comfortable with finding items which have a rel="galleryName" attribute but are not part of the nyroModal class (group). And further as of version 1.5.0, there is this nice feature how many items in the gallery are. But if it displays only 1/1 this is rather dispensable information.
May 15, 2009
As there is many way to open a nyroModal, I don't want to force dev to add the nyroModal class on everything they want to open. Don't forget that's not a requirement, but just a shortcut! In the next release, the title won't be updated if there is only 1 element in the gallery.
Jul 17, 2009
the version 1.5.1 just released should fix this issue. |
||||||||