My favorites | Sign in
Project Home Downloads Issues
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 192: Incorrect positioning caused by wrong browser version detection in IE 7 with mail.ru agent software
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Apr 2009


 
Reported by plato...@gmail.com, Mar 11, 2009
There's a problem in browser version recognition code. Mail.Ru Agent
software adds its version in IE userAgent string like this:

    mozilla/4.0 (compatible; msie 7.0; windows nt 5.1; mra 4.9 (build 01863))

Notice the mra word added by mail.ru agent. It confuses browser version
detection code (that was, obviously, copied from jquery):

    var browserVersion = (userAgent.match( /.+(?:rv|it|ra|ie)[\/:
]([\d.]+)/ ) || [0,'0'])[1];
    var isIE6 = (/msie/.test(userAgent) && !/opera/.test(userAgent) &&
parseInt(browserVersion) < 7);

In this case the version detection regular expression erroneously considers
browser version to be 4.9, that is equals 4 after parseInt(). That's why
isIE6 flag becomes true in IE 7. This causes incorrect positioning of
nyroModal content and background.

To avoid this bug I suggest using full engine names insted of two-letter
shortenings in browser detection regexp. Example:

    var browserVersion = (userAgent.match(
/.+(?:rv|webkit|khtml|opera|msie)[\/: ]([\d.]+)/ ) || [0,'0'])[1];

Apr 9, 2009
Project Member #1 nyro...@gmail.com
thanks for your code.
it will be added in the next release.
Status: Fixed
May 14, 2009
Project Member #2 nyro...@gmail.com
After a while, the version 1.5.0 is now here and fix this issue.

Powered by Google Project Hosting