Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libyan BCL zone is broken #220

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Closed

Libyan BCL zone is broken #220

GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

One of our unit tests fails, because it looks like the BCL is broken. The first 
DST transition is meant to be at 2012-01-01T00:00:00 local time (according to 
the adjustment rule) but it appears to actually occur at 2012-01-01T00:00:00Z. 
(In every other case, the adjustment rule is treated as being local time.)

Have filed a connect bug about it:
https://connect.microsoft.com/VisualStudio/feedback/details/787282/libyan-time-z
one-has-incorrect-initial-transition#details

We'll see what happens to it before deciding what to do in Noda Time.

Original issue reported on code.google.com by jonathan.skeet on 21 May 2013 at 1:36

@GoogleCodeExporter
Copy link
Author

It's been acknowledged as a BCL bug, although with an odd comment which 
suggests that the responder didn't quite understand what I'd said.

This only makes a difference for a single hour (in the past) in Libya, in a 
time zone which I suspect doesn't bear much resemblance to reality anyway.

For the moment at least, I'm just suppressing that one transition in the tests.

Original comment by jonathan.skeet on 23 May 2013 at 3:35

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Did we actually implement a fix here, or just suppress the test?

Should this actually be WontFix?

Original comment by malcolm.rowe on 26 Jul 2013 at 10:05

@GoogleCodeExporter
Copy link
Author

Well, if it's ever fixed in the BCL we should unsuppress the test, but I 
suspect that won't happening. So marked as WontFix. 

Original comment by jonathan.skeet on 26 Jul 2013 at 10:21

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants