Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositePattern is useful - we should expose this functionality externally #147

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 8 comments
Milestone

Comments

@GoogleCodeExporter
Copy link

Use case: parse a value which is in one of many formats.

See http://stackoverflow.com/questions/13316142

Original issue reported on code.google.com by jonathan.skeet on 11 Nov 2012 at 9:04

@GoogleCodeExporter
Copy link
Author

Original comment by malcolm.rowe on 25 Jan 2013 at 9:23

  • Added labels: Type-Enhancement, Priority-Low, Milestone-1.2-consider

@GoogleCodeExporter
Copy link
Author

This is now a bit trickier - CompositePattern uses and implements 
IPartialPattern, which we're not exposing. We could expose a simpler version, 
of course...

Original comment by jonathan.skeet on 9 Apr 2013 at 8:15

@GoogleCodeExporter
Copy link
Author

Any thoughts about the feasibility/desirability of doing this for 1.2.0?

Original comment by malcolm.rowe on 26 Jul 2013 at 10:08

@GoogleCodeExporter
Copy link
Author

I don't think there's enough requirement for it right now - it's easy enough to 
work around, after all, and IPartialPattern makes it harder. Marking as WontFix 
for now, but could easily revisit later.

Original comment by jonathan.skeet on 26 Jul 2013 at 10:23

  • Changed state: WontFix

@lundmikkel
Copy link

Is this still not possible?

@jskeet
Copy link
Member

jskeet commented Oct 26, 2016

@lundmikkel: Not sure what you mean by "not possible" - we could expose it, but we still haven't done so yet. (If we do so, it would be for 2.0 rather than 1.3; we could potentially do it in 1.4 as well.)

@lundmikkel
Copy link

Yeah, by possible I meant, if it was possible for users of the library to use it. As we talked about elsewhere, it seems that composite patterns could solve some problems, that are otherwise hard to solve. Especially when ParseResult<T> is also internal.

@jskeet
Copy link
Member

jskeet commented Jan 4, 2017

Yup - the ISO case is a particularly compelling one. It's niche, sure - but handy. Will need to check the API carefully, but I think I should be able to get this into 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants