Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoJson Reader is depenant on the ordering of the fields in the GeoJson #152

Closed
lawrencegripper opened this issue Feb 10, 2017 · 3 comments
Closed

GeoJson Reader is depenant on the ordering of the fields in the GeoJson #152

lawrencegripper opened this issue Feb 10, 2017 · 3 comments

Comments

@lawrencegripper
Copy link

lawrencegripper commented Feb 10, 2017 •
edited

NetTopologySuite/NetTopologySuite.IO/NetTopologySuite.IO.GeoJSON/Converters/FeatureConverter.cs

Line 87 in d6a27c2

while (reader.TokenType == JsonToken.PropertyName)

If you have a valid geojson object like this, which doesn't list the type property first, the reader will fail:

{"geometry":{"coordinates":[-90.0,-3.0000000000000004],"type":"Point"},"properties":{},"type":"Feature"}

Would you to happy to accept a pull request from me to fix this up?
@DGuidi
Copy link
Contributor

DGuidi commented Feb 10, 2017

yep, but try first if error happens also with current (master) version

@lawrencegripper
Copy link
Author

Ah thank you, it has indeed already been fixed!

@DGuidi
Copy link
Contributor

DGuidi commented Feb 10, 2017

so I can close this issue, right?

@DGuidi DGuidi closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DGuidi @lawrencegripper