| Issue 21: | LoadMethodsAction and RunTestsAction require major refactoring | |
| 1 person starred this issue and may be notified of changes. | Back to list |
this issue is to keep this on my radar. Both work just fine. however, i believe they're both terribly coded and quite embarassing. they are first-shot attempts and the more i learn about eclipse programming, the more i think I know how they should be written. i believe I need: 1) get the URL fetcher into a separate class 2) get the WS call setup into a separate class 3) get the view out of the action. this is the biggest change. it will require: -- passing in just the model (treeviewer.gettree().getdata()), which is a TestSuite object -- setting up an observer on the model, inside the view, such that when the model is changed, the observer handles updating the view asynchronously. -- this will probably require the addition of a ModelChangedEvent or some such thing structured such that I can tell it at a granular level about the changes that happened in each test case. this would include the addition of methods and the modification of existing methods (i.e. status change) -- ideally remove all the thread junk i had to add for the asynchronous interaction with the treeviewer. hopefully i can move all that ugliness into the observer and just have this class focused on running the test and updating the model and having other non-action code worry about keeping the interface updated
Nov 4, 2007
Project Member
#1
marc.es...@gmail.com
Status:
Fixed
|