| Issue 128: | assertQueryRowCount seems not useful | |
| 1 person starred this issue and may be notified of changes. | Back to list |
|
i'd have expected assertQueryRowCount to accept a query as an arg and an expected count as the other arg. instead, this just accepts two numbers. so it's no more useful than just calling assertEQuals(). i say we either fix the assertion or get rid of it entirely since it doesn't really add value
Jul 8, 2008
actually.... do you guys think this should even be in here? I ask because I would hate to see the AssertExtensions cfc become a dumping ground for assertions that are only marginally useful. like, this test could simply be done as: assertEquals(1,query.recordcount) and that's just as readable and "tells the same story" as assertQueryRowCount(1,myquery) what think ye?
Jul 8, 2008
I agree in large, but on the outside chance that there is actually someone using this, maybe we should just add a deprecation message to the message param or something?
Jul 8, 2008
i took this out. if we feel it has merit, we can put it back in
Status:
Fixed
Jul 8, 2008
BAH! I say we just put it in the release notes and the blog post under a "significant changes" section. but.... it's your call! |
||||||||||
Cc: virtix