Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in Moose-Algos-Graph + add GraphReducer + add TopologicalSorting #1117

Closed
seandenigris opened this issue Aug 3, 2015 · 8 comments
Closed

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1117

Cleanup in Moose-Algos-Graph

Reported by christophe.demarey@inria.fr on 2015-03-27 13:31:53

@seandenigris
Copy link
Contributor Author

Cleanup in Moose-Algos-Graph
- add comments
- remove useless traits
- remove duplicated code
- introduce new generic nodes: MalNodeWithNext and MalNodeWithPreviousAndNext

Add 2 alogorithms:
- Graph reducer: obtain a graph without circuits from a graph with circuits (circuits
merged in one node)
- Topological sorting: well known sort algorithm for acyclic graphes.

Reported by christophe.demarey@inria.fr on 2015-03-27 13:35:15

@seandenigris
Copy link
Contributor Author

Thanks a lot for looking into this part of Moose.

It seems that in the meantime, the tests are red. Could you check if it is related
to this issue?

Reported by tudor@tudorgirba.com on 2015-03-27 14:06:52

@seandenigris
Copy link
Contributor Author

of course. It is strange, it looks like a new class was not commited.
I check that now

Reported by christophe.demarey@inria.fr on 2015-03-27 15:31:46

@seandenigris
Copy link
Contributor Author

ok, there was an unmerged version. The latest version I published was not loaded.
I did the merge and updated the code accordingly.

There is still a problem related to the removal of the trait MalTNodeNode. I though
that I found all users of it but there is at least one remaining, preventing the loader
to load some classes.

Reported by christophe.demarey@inria.fr on 2015-03-27 22:21:52

@seandenigris
Copy link
Contributor Author

In a previous image, MalTNodeNode users gives:
an IdentitySet(FAMIXGraphNode MalSndNode MalTraverserGraphNode MalHitsNode MalNextNode).
All these classes have been updated and do not use anymore the trait.

Reported by christophe.demarey@inria.fr on 2015-03-27 22:26:18

@seandenigris
Copy link
Contributor Author

Thanks again. Still, the moose build is broken due to a Trait. Could you look at it?
https://ci.inria.fr/moose/job/moose-5.1/

Reported by tudor@tudorgirba.com on 2015-03-27 22:32:05

@seandenigris
Copy link
Contributor Author

now fixed!
I got trapped by Monticello branch mechanism. My last publication of a package was
not loaded for the CI tests.

Reported by christophe.demarey@inria.fr on 2015-03-27 22:54:50

@SergeStinckwich
Copy link
Member

Apparently fixed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants