Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to get the rawSelection in a GLMPresentation even if noSelection is used #1106

Closed
seandenigris opened this issue Aug 3, 2015 · 2 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1106

A GLMPresentation does not allow to get the selected value if the option noSelection
is specified. It looks right but ... noSelection is used if we don't want to trigger
a transmission to the selection port (and open a new pane in GTInspector for example).
In this case, it makes sense to always populate the rawSelection so that the selection
remains available to other actions.

To do that, only a small change is needed in GLMPresentation>>selection:
selection: anObject
    "Tell the pane about the new selection. This method is called when the user changes
a view's selection' (e.g., he clicks on an element in a list morph)." 
    (self pane port: #rawSelection) value: anObject.
    self acceptsSelection ifFalse: [^ self].
    rawSelectionTransmissions do: #transmit

Reported by christophe.demarey@inria.fr on 2015-01-27 10:19:43

@seandenigris
Copy link
Contributor Author

Implemented in Glamour-Core-ChristopheDemarey.290 and Glamour-Tests-Core-ChristopheDemarey.103.
Commited in the core repository

Reported by christophe.demarey@inria.fr on 2015-01-27 10:23:22

@girba
Copy link
Member

girba commented Jun 9, 2017

This is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants