Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextPresentation should update rendering when text port is populated #1046

Closed
seandenigris opened this issue Aug 3, 2015 · 4 comments
Closed

TextPresentation should update rendering when text port is populated #1046

seandenigris opened this issue Aug 3, 2015 · 4 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1046

This should update the rendering to '42':

    composite := GLMCompositePresentation new with: [:a | a text ].
    composite openOn: 'fourtytwo'.
    composite first text: '42'.

Reported by tudor@tudorgirba.com on 2014-02-08 23:15:02
@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2014-02-08 23:23:17

  • Status changed: Fixed

@seandenigris
Copy link
Contributor Author 

Reverted the change for now.

Name: Glamour-Morphic-Renderer-TudorGirba.225
Author: TudorGirba
Time: 10 February 2014, 6:39:53.053388 am
UUID: f7f54f9b-4177-4e87-8751-5d7c7e616dd2
Ancestors: Glamour-Morphic-Renderer-TudorGirba.224

commented out the text updating because it seems to disturb copy-pasting and cmd+shift+left
arrow :(


Issue 1046: TextPresentation should update rendering when text port is populated

Reported by tudor@tudorgirba.com on 2014-02-10 05:40:10

@seandenigris
Copy link
Contributor Author 

The problem is located in the commented code from below:

GLMMorphicTextRenderer>>actOnContextChanged: ann 
    ann property = #selectionInterval
        ifTrue: [ 
            ann value notNil 
                ifTrue: [textMorph setSelection: ann value ]
                ifFalse: [textMorph setSelection: (1 to: 0)] ].
"   self flag: 'somehow this disturbs copy paste and cmd+shift+left selection'.
    ann property = #text
        ifTrue: [ 
            textMorph announcer suspendAll: {GLMTextChanged} while: [ 
                    textModel changedText: ann value ] ]"

Reported by tudor@tudorgirba.com on 2014-02-10 05:40:46

  • Status changed: Accepted

@seandenigris
Copy link
Contributor Author

Reported by tudor@tudorgirba.com on 2014-11-25 07:34:23

  • Labels removed: Milestone-5.0

@badetitou badetitou removed the Defect label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seandenigris @badetitou