Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glamour easel and GTDebugger #1034

Closed
seandenigris opened this issue Aug 3, 2015 · 5 comments
Closed

Glamour easel and GTDebugger #1034

seandenigris opened this issue Aug 3, 2015 · 5 comments

Comments

@seandenigris
Copy link
Contributor

Originally reported on Google Code with ID 1034

Hi!

I have spotted an important bug. If I enter the following in the Glamour Roassal easel:
view nodes: (1 to: 20).
self halt.

A debugger is open, but I cannot step in. Apparently the code source is not accessible.
This is a major regression...

Reported by alexandre.bergel on 2013-12-19 09:25:19
@seandenigris
Copy link
Contributor Author 

This is not related to the debugger, but to the changes induced Opal. It seems that
GLMDoItContext is not compliant anymore.

Can someone more knowledgeable take a look at this?

Reported by tudor@tudorgirba.com on 2013-12-19 11:00:05

  • Labels added: Component-Glamour, Milestone-5.0

@seandenigris
Copy link
Contributor Author 

The problem appears because the code is compiled into a method without source code,
and then when it's executed the source code seems to be needed. It can be solved by
setting a notifier object when calling the compiler: in GLMRoassalEasel>>evaluate:in:for:


Smalltalk compiler 
            evaluate: script 
            in: context 
            to: context
            notifying: self
            ifFail: [^ #failedDoit]

Seems to work, but I'm not sure exactly what the notifier should do.

Reported by chisvasileandrei on 2013-12-19 14:04:46

@seandenigris
Copy link
Contributor Author 

Added the fix to all other esels

Reported by chisvasileandrei on 2013-12-20 14:07:06

@seandenigris
Copy link
Contributor Author 

If I do in the Roassal Easel (or other ones):

view halt

I get this at the moment:

DoItIn: ThisContext
    ^ (ThisContext namedTempAt: 1) halt 

Can we not get the actual source?

Reported by tudor@tudorgirba.com on 2014-01-10 04:14:57

@seandenigris
Copy link
Contributor Author 

As far as I can tell, this is fixed now. Let me know if you still have problems in this
area.

Reported by tudor@tudorgirba.com on 2014-10-04 06:00:46

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seandenigris