Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing modular themes trough a "class" attribute #474

Closed
mapsforge opened this issue Nov 6, 2014 · 3 comments
Closed

Introducing modular themes trough a "class" attribute #474

mapsforge opened this issue Nov 6, 2014 · 3 comments

Comments

@mapsforge
Copy link
Owner

From tartami...@gmail.com on December 26, 2013 18:09:20

Building a Mapsforge theme involves a lot of compromise about what to show and when, which leads to building unnecessary forks that are difficult to maintain an use and/or to cluttered maps. This would be much more simple to handle if we could have a mean to give the end-user some choice on display decisions hiding stuff that's not needed in that moment to unclutter the map.

Adding an optional class attribute would allow the end user to filter elements shown on the map in a very simple way.
Syntax is simple, class="name1,name2,nameN".
The xml is parsed and the list of classes is shown to the user in form of a check-boxed list, for example in an easy to access lateral drawer. When drawing the map, only instructions with at least one class checked are executed. Of course instructions without a class are always executed.

To maximize flexibility the class attribute should be usable on every instruction, not only . However if a is turned off everything inside it is ignored, regardless of its own classes.

A mechanism to determine what classes are checked by default, and maybe to define groups of mutually exclusive classes, would add further usefulness (a lot, actually). But I think it can come independently at a later stage.

Original issue: http://code.google.com/p/mapsforge/issues/detail?id=474

@mapsforge
Copy link
Owner Author

From jjbross@gmail.com on January 26, 2014 04:09:23

Labels: -Type-Defect Type-Enhancement

@mapsforge
Copy link
Owner Author

From LudwigBr...@gmail.com on February 21, 2014 00:26:05

Check the rescue-exp branch at https://code.google.com/r/ludwigbrinckmann-mapsforge/source/browse?name=rescue-exp for this.

Rules can have a cat(egory) that can be turned on or off when the rendertheme is constructed. There is only one cat per rule, I think you can actually devise what you are suggesting with a single cat per rule.

Status: Started

@ludwigb
Copy link
Collaborator

ludwigb commented Dec 3, 2014

I think the suggestions are now all implemented in Rendertheme V4.

@ludwigb ludwigb closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants